Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maturin, pyo3, add free-threaded 3.13t wheel #47

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

ddelange
Copy link
Collaborator

@ddelange ddelange commented Dec 4, 2024

ready for review but still need to bump version after release of gh-action-pypi-publish ^

@ddelange
Copy link
Collaborator Author

ddelange commented Dec 4, 2024

cc @oconnor663

@ddelange
Copy link
Collaborator Author

ddelange commented Dec 4, 2024

hmm, looks like the fix for windows 3.13 no longer works? PyO3/maturin-action#292 (comment)

regardless of 3.13 / 3.13t

@davidhewitt
Copy link

does it work if you enable PyO3's generate-import-lib feature? 🤔

@davidhewitt
Copy link

It looks to me like the lib path is missing for some reason, can you use PYO3_PRINT_CONFIG=1 env with just --interpreter 3.13? Might give us some hints...

@ddelange
Copy link
Collaborator Author

ddelange commented Dec 4, 2024

@davidhewitt

  -- PYO3_PRINT_CONFIG=1 is set, printing configuration and halting compile --
  implementation=CPython
  version=3.13
  shared=true
  abi3=false
  lib_name=python313
  lib_dir=C:\hostedtoolcache\windows\Python\3.13.0\x64\libs
  executable=C:\hostedtoolcache\windows\Python\3.13.0\x64\python.exe
  pointer_width=64
  build_flags=
  suppress_build_script_link_lines=false

@ddelange
Copy link
Collaborator Author

ddelange commented Dec 4, 2024

@davidhewitt looks like adding generate-import-lib worked! Can you explain what happened here?

@davidhewitt
Copy link

Great! The generate-import-lib feature allows PyO3 to do exactly that - produce the library shim to link against instead of requiring one.

As to why the original library was not present, I'm not sure. I can try to debug that another time.

@ddelange ddelange marked this pull request as ready for review December 4, 2024 15:57
@oconnor663
Copy link
Owner

@ddelange thanks for being so on top of this stuff. At this point you're doing more to maintain the project than I am. I'm going to go ahead and make you a repo maintainer. If I ever go a few months without reviewing PRs again, I trust you to do what you think is best :)

@oconnor663 oconnor663 merged commit 217473b into oconnor663:master Dec 5, 2024
111 checks passed
@ddelange
Copy link
Collaborator Author

ddelange commented Dec 5, 2024

@oconnor663 awesome, thanks for the trust and looking forward to collaborating!

now watching all activity!

https://http.cat/202

P.S. soon you'll see a small PR incoming to bump gh-action-pypi-publish as soon as they release (also watching that one)

@ddelange
Copy link
Collaborator Author

ddelange commented Dec 6, 2024

awaiting upstrean release: maturin is now included in their CI 🎉

pypa/gh-action-pypi-publish#313

@ddelange
Copy link
Collaborator Author

hi @davidhewitt 👋

this error is back on main, despite generate-import-lib now being present. any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants