-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump maturin, pyo3, add free-threaded 3.13t wheel #47
Conversation
cc @oconnor663 |
This reverts commit 66475ce.
hmm, looks like the fix for windows 3.13 no longer works? PyO3/maturin-action#292 (comment) regardless of 3.13 / 3.13t |
does it work if you enable PyO3's |
It looks to me like the lib path is missing for some reason, can you use |
|
@davidhewitt looks like adding generate-import-lib worked! Can you explain what happened here? |
Great! The As to why the original library was not present, I'm not sure. I can try to debug that another time. |
@ddelange thanks for being so on top of this stuff. At this point you're doing more to maintain the project than I am. I'm going to go ahead and make you a repo maintainer. If I ever go a few months without reviewing PRs again, I trust you to do what you think is best :) |
@oconnor663 awesome, thanks for the trust and looking forward to collaborating! now watching all activity! P.S. soon you'll see a small PR incoming to bump gh-action-pypi-publish as soon as they release (also watching that one) |
awaiting upstrean release: maturin is now included in their CI 🎉 |
hi @davidhewitt 👋 this error is back on main, despite |
3.13t
free-threaded python wheels (supported as of maturin 1.7.6)ready for review but still need to bump version after release of gh-action-pypi-publish ^